Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix profiling plugin for next build #21989

Merged
merged 3 commits into from
Feb 9, 2021
Merged

Fix profiling plugin for next build #21989

merged 3 commits into from
Feb 9, 2021

Conversation

timneutkens
Copy link
Member

Makes sure yarn trace build works.

@ijjk ijjk added the type: next label Feb 9, 2021
@ijjk
Copy link
Member

ijjk commented Feb 9, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js fix/next-build-trace Change
buildDuration 11.4s 11.2s -235ms
nodeModulesSize 75.3 MB 75.3 MB ⚠️ +171 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary timneutkens/next.js fix/next-build-trace Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.245 2.294 ⚠️ +0.05
/ avg req/sec 1113.76 1089.68 ⚠️ -24.08
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.513 1.593 ⚠️ +0.08
/error-in-render avg req/sec 1652.62 1569.61 ⚠️ -83.01
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js fix/next-build-trace Change
677f882d2ed8..49c4.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.63 kB 6.63 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 59.5 kB 59.5 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/next-build-trace Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js fix/next-build-trace Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
hooks-c71ae4..70cd.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/next-build-trace Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js fix/next-build-trace Change
index.html gzip 615 B 615 B ✓
link.html gzip 620 B 620 B ✓
withRouter.html gzip 608 B 608 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js fix/next-build-trace Change
buildDuration 13.4s 13.4s -19ms
nodeModulesSize 75.3 MB 75.3 MB ⚠️ +171 B
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js fix/next-build-trace Change
677f882d2ed8..49c4.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.63 kB 6.63 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 59.5 kB 59.5 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/next-build-trace Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js fix/next-build-trace Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
hooks-c71ae4..70cd.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/next-build-trace Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Serverless bundles
vercel/next.js canary timneutkens/next.js fix/next-build-trace Change
_error.js 1 MB 1 MB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.06 MB 1.06 MB ✓
withRouter.js 1.06 MB 1.06 MB ✓
Overall change 5.19 MB 5.19 MB ✓
Webpack 5 Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js fix/next-build-trace Change
buildDuration 13.7s 13.8s ⚠️ +98ms
nodeModulesSize 75.3 MB 75.3 MB ⚠️ +171 B
Page Load Tests Overall increase ✓
vercel/next.js canary timneutkens/next.js fix/next-build-trace Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.247 2.247 ✓
/ avg req/sec 1112.56 1112.48 ⚠️ -0.08
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.768 1.571 -0.2
/error-in-render avg req/sec 1414.2 1591.18 +176.98
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js fix/next-build-trace Change
597-6c246419..806f.js gzip 13 kB 13 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 6.58 kB 6.58 kB ✓
webpack-HASH.js gzip 954 B 954 B ✓
Overall change 59.9 kB 59.9 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/next-build-trace Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js fix/next-build-trace Change
_app-6e0a903..b885.js gzip 1.26 kB 1.26 kB ✓
_error-7a100..a392.js gzip 3.38 kB 3.38 kB ✓
hooks-f7e199..11b9.js gzip 904 B 904 B ✓
index-3dc22c..ffbb.js gzip 232 B 232 B ✓
link-c010d28..b60a.js gzip 1.63 kB 1.63 kB ✓
routerDirect..323a.js gzip 308 B 308 B ✓
withRouter-a..2ef8.js gzip 304 B 304 B ✓
Overall change 8.02 kB 8.02 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/next-build-trace Change
_buildManifest.js gzip 299 B 299 B ✓
Overall change 299 B 299 B ✓
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js fix/next-build-trace Change
index.html gzip 584 B 584 B ✓
link.html gzip 591 B 591 B ✓
withRouter.html gzip 578 B 578 B ✓
Overall change 1.75 kB 1.75 kB ✓

Diffs

Diff for index.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "UhaWCdQqyLsnzoXwvRu0D",
+        "buildId": "c2InUpSC850dA9GULg2ej",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/UhaWCdQqyLsnzoXwvRu0D/_buildManifest.js"
+      src="/_next/static/c2InUpSC850dA9GULg2ej/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/UhaWCdQqyLsnzoXwvRu0D/_ssgManifest.js"
+      src="/_next/static/c2InUpSC850dA9GULg2ej/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html 
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "UhaWCdQqyLsnzoXwvRu0D",
+        "buildId": "c2InUpSC850dA9GULg2ej",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/UhaWCdQqyLsnzoXwvRu0D/_buildManifest.js"
+      src="/_next/static/c2InUpSC850dA9GULg2ej/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/UhaWCdQqyLsnzoXwvRu0D/_ssgManifest.js"
+      src="/_next/static/c2InUpSC850dA9GULg2ej/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "UhaWCdQqyLsnzoXwvRu0D",
+        "buildId": "c2InUpSC850dA9GULg2ej",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/UhaWCdQqyLsnzoXwvRu0D/_buildManifest.js"
+      src="/_next/static/c2InUpSC850dA9GULg2ej/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/UhaWCdQqyLsnzoXwvRu0D/_ssgManifest.js"
+      src="/_next/static/c2InUpSC850dA9GULg2ej/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: dd0a18e

@ijjk

This comment has been minimized.

Sign in to view
@ijjk
Copy link
Member

ijjk commented Feb 9, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js fix/next-build-trace Change
buildDuration 11s 10.7s -292ms
nodeModulesSize 75.3 MB 75.3 MB ⚠️ +171 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary timneutkens/next.js fix/next-build-trace Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.243 2.242 0
/ avg req/sec 1114.49 1115.17 +0.68
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.553 1.569 ⚠️ +0.02
/error-in-render avg req/sec 1609.76 1593.36 ⚠️ -16.4
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js fix/next-build-trace Change
677f882d2ed8..49c4.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.63 kB 6.63 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 59.5 kB 59.5 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/next-build-trace Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js fix/next-build-trace Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
hooks-c71ae4..70cd.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/next-build-trace Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js fix/next-build-trace Change
index.html gzip 615 B 615 B ✓
link.html gzip 620 B 620 B ✓
withRouter.html gzip 608 B 608 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js fix/next-build-trace Change
buildDuration 13s 12.9s -31ms
nodeModulesSize 75.3 MB 75.3 MB ⚠️ +171 B
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js fix/next-build-trace Change
677f882d2ed8..49c4.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.63 kB 6.63 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 59.5 kB 59.5 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/next-build-trace Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js fix/next-build-trace Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
hooks-c71ae4..70cd.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/next-build-trace Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Serverless bundles
vercel/next.js canary timneutkens/next.js fix/next-build-trace Change
_error.js 1 MB 1 MB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.06 MB 1.06 MB ✓
withRouter.js 1.06 MB 1.06 MB ✓
Overall change 5.19 MB 5.19 MB ✓
Webpack 5 Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js fix/next-build-trace Change
buildDuration 13.7s 13.4s -221ms
nodeModulesSize 75.3 MB 75.3 MB ⚠️ +171 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary timneutkens/next.js fix/next-build-trace Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.253 2.281 ⚠️ +0.03
/ avg req/sec 1109.7 1096.09 ⚠️ -13.61
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.541 1.58 ⚠️ +0.04
/error-in-render avg req/sec 1622 1582.37 ⚠️ -39.63
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js fix/next-build-trace Change
597-6c246419..806f.js gzip 13 kB 13 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 6.58 kB 6.58 kB ✓
webpack-HASH.js gzip 954 B 954 B ✓
Overall change 59.9 kB 59.9 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/next-build-trace Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js fix/next-build-trace Change
_app-6e0a903..b885.js gzip 1.26 kB 1.26 kB ✓
_error-7a100..a392.js gzip 3.38 kB 3.38 kB ✓
hooks-f7e199..11b9.js gzip 904 B 904 B ✓
index-3dc22c..ffbb.js gzip 232 B 232 B ✓
link-c010d28..b60a.js gzip 1.63 kB 1.63 kB ✓
routerDirect..323a.js gzip 308 B 308 B ✓
withRouter-a..2ef8.js gzip 304 B 304 B ✓
Overall change 8.02 kB 8.02 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/next-build-trace Change
_buildManifest.js gzip 299 B 299 B ✓
Overall change 299 B 299 B ✓
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js fix/next-build-trace Change
index.html gzip 584 B 584 B ✓
link.html gzip 591 B 591 B ✓
withRouter.html gzip 578 B 578 B ✓
Overall change 1.75 kB 1.75 kB ✓

Diffs

Diff for index.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "X2Ul6BenMfw-uxNKvm_vS",
+        "buildId": "uWCWdBjefAimANLUA_lSG",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/X2Ul6BenMfw-uxNKvm_vS/_buildManifest.js"
+      src="/_next/static/uWCWdBjefAimANLUA_lSG/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/X2Ul6BenMfw-uxNKvm_vS/_ssgManifest.js"
+      src="/_next/static/uWCWdBjefAimANLUA_lSG/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html 
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "X2Ul6BenMfw-uxNKvm_vS",
+        "buildId": "uWCWdBjefAimANLUA_lSG",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/X2Ul6BenMfw-uxNKvm_vS/_buildManifest.js"
+      src="/_next/static/uWCWdBjefAimANLUA_lSG/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/X2Ul6BenMfw-uxNKvm_vS/_ssgManifest.js"
+      src="/_next/static/uWCWdBjefAimANLUA_lSG/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "X2Ul6BenMfw-uxNKvm_vS",
+        "buildId": "uWCWdBjefAimANLUA_lSG",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/X2Ul6BenMfw-uxNKvm_vS/_buildManifest.js"
+      src="/_next/static/uWCWdBjefAimANLUA_lSG/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/X2Ul6BenMfw-uxNKvm_vS/_ssgManifest.js"
+      src="/_next/static/uWCWdBjefAimANLUA_lSG/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: 6e9a3a8

@kodiakhq kodiakhq bot merged commit 6b99bda into vercel:canary Feb 9, 2021
@timneutkens timneutkens deleted the fix/next-build-trace branch February 10, 2021 09:12
This was referenced Feb 16, 2021
Open
Open
Open
This was referenced Apr 12, 2021
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Jan 18, 2022
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Closed
Open
Open
Open
Open
Open
Open
Open
Open
Open
@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@divmain divmain divmain approved these changes

@lfades lfades Awaiting requested review from lfades

@Timer Timer Awaiting requested review from Timer

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@timneutkens @ijjk @divmain